address comments

CHANGELOG.md

@@ -4,9 +4,10 @@ Please add your own contribution below inside the Master section
 
 ## Master
 * brief change description - @author
-* show release message once per workspace - @connetdotz
 -->
 
+### 4.1.1
+* show release message once per workspace - @connetdotz (#756)
 ### 4.1.0
 * fix type warning in settings.json when using the `{"autoRun": "off"}` option - @tommy
 * fix couple of test result matching issues - @connectdotz (#737)

package.json

@@ -2,7 +2,7 @@
   "name": "vscode-jest",
   "displayName": "Jest",
   "description": "Use Facebook's Jest With Pleasure.",
-  "version": "4.1.0",
+  "version": "4.1.1",
   "publisher": "Orta",
   "engines": {
     "vscode": "^1.59.0"

src/extensionManager.ts

@@ -282,14 +282,14 @@ export class ExtensionManager {
     if (!didShow) {
       vscode.window
         .showInformationMessage(
-          `vscode-jest now supports the official vscode test explorer!!`,
+          `vscode-jest now supports the official vscode test explorer.`,
           'Show Test Explorer',
           'See Details'
         )
         .then((value) => {
           if (value === 'Show Test Explorer') {
             vscode.commands.executeCommand('workbench.view.testing.focus');
-          } else {
+          } else if (value === 'See Details') {
             vscode.commands.executeCommand(
               'vscode.open',
               vscode.Uri.parse(

tests/extensionManager.test.ts

@@ -645,6 +645,13 @@ describe('ExtensionManager', () => {
           )
         );
       });
+      it('if close without selecting any action, should exit with no-op', async () => {
+        (vscode.window.showInformationMessage as jest.Mocked<any>).mockReturnValue(
+          Promise.resolve(undefined)
+        );
+        await extensionManager.activate();
+        expect(vscode.commands.executeCommand).not.toBeCalled();
+      });
       it('will not show again once it has been seen', async () => {
         (vscode.window.showInformationMessage as jest.Mocked<any>).mockReturnValue(
           Promise.resolve('Show Test Explorer')