Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong tests being marked when line-number out of sync #349

Closed
connectdotz opened this issue Jul 14, 2018 · 1 comment
Closed

wrong tests being marked when line-number out of sync #349

connectdotz opened this issue Jul 14, 2018 · 1 comment

Comments

@connectdotz
Copy link
Collaborator

Environment

  1. node -v: 8.9.1

  2. npm -v: 3.10.10 (yarn: 1.7.0)

  3. npm ls react-scripts (if you haven’t ejected): n/a

  4. Operating system: macOS 10.13.5

Steps to Reproduce

the vscode-jest repo is the perfect example. It currently has source-map issue which caused the ts src line number got out of sync with the generated js files that used by jest. add a simple failed test case to make sure the actual test error line number reported by jest falls to the other test block.

Expected Behavior

it's ok not to mark the actual line that caused the error since the linenumber is wrong, but we should not mark the wrong test when the name clearly does not match.

Actual Behavior

The itBlock where the line number falls into, as well as the itBlock matches the actual failed test by name, will both be marked as failed.


Note we are looking for someone to take responsibility around keeping create-react-app up to date and working, could this be you?

connectdotz added a commit to connectdotz/vscode-jest that referenced this issue Jul 14, 2018
@connectdotz
Copy link
Collaborator Author

vscode-jest 2.9.0 has shipped with jest 23.x support and more, which should address this issue. Feel free to reopen if otherwise.

legend1202 pushed a commit to legend1202/vscode-jest that referenced this issue Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant