Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test status indicator issue #36

Closed
yantakus opened this issue Dec 5, 2016 · 8 comments · Fixed by #674
Closed

Test status indicator issue #36

yantakus opened this issue Dec 5, 2016 · 8 comments · Fixed by #674

Comments

@yantakus
Copy link

yantakus commented Dec 5, 2016

When there's a failing test, the indicator turns red:

test js - first-agenda 2016-12-05 11-41-18

When I fix it, the comment disappears, but the indicator is still red:

test js - first-agenda 2016-12-05 11-41-38

@orta
Copy link
Member

orta commented Dec 5, 2016

oh yeah, that's weird, I've not seen this before - can you clone the repo and have a look with the debugger at the status of that it? Is there two wit the same name by any chance?

@bookman25
Copy link
Collaborator

When you fix it, are the files you're modifying back to an unchanged state in git (unstaged/uncommited)?

I've seen one case if you fix and either commit, or the fix goes back to unchanged state. Jest is only acting on unstaged/uncommited files and as a result the editor doesn't currently update the decorators for files it thinks have no changes.

@bookman25
Copy link
Collaborator

We made some improvements here, if you're still seeing the issue feel free to reopen.

@thedgbrt
Copy link

Still seeing this with latest version

@bookman25
Copy link
Collaborator

bookman25 commented Mar 16, 2017

I've also seen variations of this as well. I'm going to try to find some time to track down the specific repro and hopefully fix. Basically there's some cases where the decorators aren't updating when they should.

@bookman25 bookman25 reopened this Mar 16, 2017
@svdHero
Copy link

svdHero commented Oct 11, 2017

Same problem here with vscode 1.16.1 and Jest extension 2.4.2 under Linux:

status_indicator_not_updating

@daldridge-cs
Copy link

daldridge-cs commented Apr 13, 2018

I've seen this occur in the following scenario:

  • Start with a test that is passing
  • Edit the test and save, causing the watcher to detect the change and run the test. Test is correctly shown as failing.
  • Undo the edits to the failing test, reverting the file back to what it was (no difference in git working tree). Because the file matches SCM, the watcher doesn't re-run the test, so it fails to go back to green.

Likely related/same as #32?

@jfcere
Copy link

jfcere commented Feb 7, 2019

@daldridge-cs I noticed the same thing and it has been reported here: #308

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants