Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[style] Indentation problem with status indicator #554

Closed
hornta opened this issue Feb 18, 2020 · 9 comments · Fixed by #599
Closed

[style] Indentation problem with status indicator #554

hornta opened this issue Feb 18, 2020 · 9 comments · Fixed by #599

Comments

@hornta
Copy link

hornta commented Feb 18, 2020

Is it possible to move the status indicator to above the test instead of having it prefixed? I don't like how it messes with the indentation.
Before when a dot was used as the indicator the indentation worked fine.

image

@Nick-Lucas
Copy link

Agreed, this is really hurting the readability of tests for me. The old design was totally fine.

@gregveres
Copy link

I didn't see the old design, but I was coming here to suggest moving the check mark to the beginning of the line and not affecting indenting if possible.

@wrslatz
Copy link

wrslatz commented Apr 18, 2020

I regularly run into this issue. This impacts my work in two main ways:

  1. moving tests becomes harder as I often mess up where the start of the test is
  2. my project lints correct spacing and indentation and I often try to fix the indentation of the tests despite there being only a visual issue with the plug-in, which then causes my linting to fail

@connectdotz
Copy link
Collaborator

those are all valid points, we could maybe try to move the indicators to the gutter? Should be a fun simple PR, the code is all in src/decorations.ts... anybody interested?

@connectdotz connectdotz mentioned this issue Apr 28, 2020
15 tasks
@seanpoulter seanpoulter added this to the v4.0 milestone May 2, 2020
@wrslatz
Copy link

wrslatz commented May 28, 2020

Might give it a try this weekend 🤔

@Tymek
Copy link
Contributor

Tymek commented Jun 25, 2020

@wrslatz image in gutterIconPath should do the trick. Are you working on it, or perhaps I could contribute to this? 🙂

@vladshcherbin
Copy link

@Tymek go for it 👍

@wrslatz
Copy link

wrslatz commented Jun 25, 2020

@wrslatz image in gutterIconPath should do the trick. Are you working on it, or perhaps I could contribute to this? 🙂

@Tymek Go for it!

@Tymek
Copy link
Contributor

Tymek commented Jun 26, 2020

PoC at my fork. PR later today

Screenshot from 2020-06-26 12-14-37

For now I will provide only one color version, without light and dark theme. Difference isn't stark and I'd like to develop more granular settings for this feature in the future: Icon styles and color configuration. It would make dark/light colors obsolete.

Details to come, let's finish one thing at a time :)

Tymek added a commit to Tymek/vscode-jest that referenced this issue Jun 26, 2020
squash eca8a9a feat: status indicator in gutter proof-of-concept
squash e115488 feat: test state indicators
squash fa38ae8 refactor: simplify test status decorators
Tymek added a commit to Tymek/vscode-jest that referenced this issue Jun 26, 2020
squash eca8a9a feat: status indicator in gutter proof-of-concept
squash e115488 feat: test state indicators
squash fa38ae8 refactor: simplify test status decorators
Tymek added a commit to Tymek/vscode-jest that referenced this issue Jun 26, 2020
squash eca8a9a feat: status indicator in gutter proof-of-concept
squash e115488 feat: test state indicators
squash fa38ae8 refactor: simplify test status decorators
Tymek added a commit to Tymek/vscode-jest that referenced this issue Jun 27, 2020
4d54331 fix: update changelog
fa38ae8 refactor: simplify test status decorators
e115488 feat: test state indicators
eca8a9a feat: status indicator in gutter proof-of-concept
Tymek added a commit to Tymek/vscode-jest that referenced this issue Jun 29, 2020
da7eaa9 refactor: status indicator svg icons
4d54331 fix: update changelog
fa38ae8 refactor: simplify test status decorators
e115488 feat: test state indicators
eca8a9a feat: status indicator in gutter proof-of-concept
Tymek added a commit to Tymek/vscode-jest that referenced this issue Jun 29, 2020
da7eaa9 refactor: status indicator svg icons
4d54331 fix: update changelog
fa38ae8 refactor: simplify test status decorators
e115488 feat: test state indicators
eca8a9a feat: status indicator in gutter proof-of-concept
Tymek added a commit to Tymek/vscode-jest that referenced this issue Jun 30, 2020
da7eaa9 refactor: status indicator svg icons
4d54331 fix: update changelog
fa38ae8 refactor: simplify test status decorators
e115488 feat: test state indicators
eca8a9a feat: status indicator in gutter proof-of-concept
Tymek added a commit to Tymek/vscode-jest that referenced this issue Jun 30, 2020
da7eaa9 refactor: status indicator svg icons
4d54331 fix: update changelog
fa38ae8 refactor: simplify test status decorators
e115488 feat: test state indicators
eca8a9a feat: status indicator in gutter proof-of-concept
Tymek added a commit to Tymek/vscode-jest that referenced this issue Jun 30, 2020
da7eaa9 refactor: status indicator svg icons
4d54331 fix: update changelog
fa38ae8 refactor: simplify test status decorators
e115488 feat: test state indicators
eca8a9a feat: status indicator in gutter proof-of-concept
@Tymek Tymek mentioned this issue Jul 1, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants