Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GutterFormatter images are not in build #585

Closed
markcarroll opened this issue May 20, 2020 · 1 comment · Fixed by #599
Closed

GutterFormatter images are not in build #585

markcarroll opened this issue May 20, 2020 · 1 comment · Fixed by #599
Labels

Comments

@markcarroll
Copy link

Environment

  1. node -v: v12.16.1

  2. npm -v: 6.14.5

  3. npm ls jest or npm ls react-scripts (if you haven’t ejected): jest@26.0.1

  4. your vscode-jest settings if customized:

    • jest.pathToJest? default
    • jest.pathToConfig? default
    • anything else that you think might be relevant? see below
  5. Operating system: macOS 10.15.4

Prerequisite

  • are you able to run jest test from command line? yes
  • how do you run your tests from command line? (for example: npm run test or node_modules/.bin/jest) jest (with npx fallback)

Steps to Reproduce

Turn on GutterFormatter in vscode settings

Relevant Debug Info

VSCode fails to load the SVG images used in the gutter formatter. It is trying to load them from:

Request URL: file:///Users/mark/.vscode/extensions/orta.vscode-jest-3.2.0/src/Coverage/Formatters/GutterFormatter/partially-covered-gutter-icon.svg

That folder is not present in extension folder.

Expected Behavior

Gutter images load.

Actual Behavior

Error as listed above.


The fastest (and the most fun) way to resolve the issue is to submit a pull-request yourself. If you are interested, feel free to check out the contribution guide, we look forward to seeing your PR...

@Tymek
Copy link
Contributor

Tymek commented Jun 30, 2020

I'll take a shot at it. My first guess is that raw-loader or something like that can help. We'll see

@Tymek Tymek mentioned this issue Jun 30, 2020
10 tasks
Tymek added a commit to Tymek/vscode-jest that referenced this issue Jun 30, 2020
e234ae6 feat: add back light theme status decorations
0c930ef refactor: use common functions from decorations
e916d74 fix: use prepared svg icon in coverage formatter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants