convert ProjectWorkspace rootPath to upper-case drive-letter in windows #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 951
💛 - Coveralls |
stephtr
approved these changes
May 27, 2021
legend1202
pushed a commit
to legend1202/vscode-jest
that referenced
this pull request
Jun 18, 2023
convert ProjectWorkspace rootPath to upper-case drive-letter in windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this ProjectWorkspace.rootPath is used by
jest-editor-supportRunner to spawn process as the "cwd". On windows, if the drive-letter is lowercase, jest process could fail under some configurations. To make it more fault-tolerant, we should convert it to uppercase.