-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show release message once per workspace #756
show release message once per workspace #756
Conversation
Pull Request Test Coverage Report for Build 1163313480
💛 - Coveralls |
@garyking feel free to review the PR so we can push it out sooner. Thx. |
src/extensionManager.ts
Outdated
if (value === 'Show Test Explorer') { | ||
vscode.commands.executeCommand('workbench.view.testing.focus'); | ||
} else { | ||
vscode.commands.executeCommand( | ||
'vscode.open', | ||
vscode.Uri.parse( | ||
'https://github.com/jest-community/vscode-jest/blob/master/README.md#how-to-use-the-test-explorer' | ||
) | ||
); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned in #755 this should exit out early if the value returned is undefined
so that when the user dismisses the prompt it doesn't open the readme
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indeed!
fix #755