Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Activate on workspaces with jest.config.{mjs|cjs|ts} #846

Merged
merged 2 commits into from
Apr 17, 2022
Merged

Activate on workspaces with jest.config.{mjs|cjs|ts} #846

merged 2 commits into from
Apr 17, 2022

Conversation

felipecrs
Copy link
Contributor

@felipecrs felipecrs commented Mar 18, 2022 •
edited

felipecrs
felipecrs commented Mar 18, 2022
View reviewed changes
package.json Show resolved Hide resolved
@felipecrs felipecrs mentioned this pull request Mar 18, 2022
Merged
@Araxeus
Copy link

Araxeus commented Apr 3, 2022

I think that for clarity this PR should be renamed to Fix extension not activating if jest.config is .mjs
also technically it could also be .ts too

@felipecrs felipecrs changed the title Fix extension not activating in docusaurus project Activate on workspaces with jest.config.{mjs|cjs|ts} Apr 4, 2022
@felipecrs
Copy link
Contributor Author

I think that for clarity this PR should be renamed to Fix extension not activating if jest.config is .mjs also technically it could also be .ts too

Added .ts and .cjs. Also fixed the PR title, I agree.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2086970678

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.383%
Totals Coverage Status
Change from base Build 1683858435: 0.0%
Covered Lines: 2567
Relevant Lines: 2638
💛 - Coveralls

connectdotz
connectdotz approved these changes Apr 17, 2022
View reviewed changes
Copy link
Collaborator

@connectdotz connectdotz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks @felipecrs

@connectdotz connectdotz merged commit 0046735 into jest-community:master Apr 17, 2022
@felipecrs felipecrs deleted the patch-1 branch April 17, 2022 20:46
legend1202 pushed a commit to legend1202/vscode-jest that referenced this pull request Jun 18, 2023
@felipecrs
Activate on workspaces with jest.config.{mjs|cjs|ts} (jest-communit…
388b0b9 
…y#846)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@connectdotz connectdotz connectdotz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@felipecrs @Araxeus @coveralls @connectdotz