jest-haste-map: only file IO errors should be silently ignored (#3816)

* jest-haste-map: only file IO errors should be silently ignored * fix tests * remove extra line
jestjs · Jun 14, 2017 · 79eed25 · 79eed25
1 parent 89c5065
commit 79eed25
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 1 deletion.
diff --git a/packages/jest-cli/src/TestWorker.js b/packages/jest-cli/src/TestWorker.js
@@ -44,6 +44,7 @@ const formatError = (error: string | Error): SerializableError => {
   }
 
   return {
+    code: error.code || undefined,
     message: error.message,
     stack: error.stack,
     type: 'Error',

diff --git a/packages/jest-cli/src/reporters/CoverageWorker.js b/packages/jest-cli/src/reporters/CoverageWorker.js
@@ -30,6 +30,7 @@ function formatCoverageError(error, filename: Path): SerializableError {
   `;
 
   return {
+    code: error.code || undefined,
     message,
     stack: error.stack,
     type: 'ERROR',

diff --git a/packages/jest-haste-map/src/__tests__/index-test.js b/packages/jest-haste-map/src/__tests__/index-test.js
@@ -136,7 +136,9 @@ describe('HasteMap', () => {
         return mockFs[path];
       }
 
-      throw new Error(`Cannot read path '${path}'.`);
+      const error = new Error(`Cannot read path '${path}'.`);
+      error.code = 'ENOENT';
+      throw error;
     });
     fs.writeFileSync = jest.fn((path, data, options) => {
       expect(options).toBe('utf8');

diff --git a/packages/jest-haste-map/src/index.js b/packages/jest-haste-map/src/index.js
@@ -407,6 +407,9 @@ class HasteMap extends EventEmitter {
         fileMetadata[H.DEPENDENCIES] = metadata.dependencies || [];
       },
       error => {
+        if (['ENOENT', 'EACCES'].indexOf(error.code) < 0) {
+          throw error;
+        }
         // If a file cannot be read we remove it from the file list and
         // ignore the failure silently.
         delete hasteMap.files[filePath];

diff --git a/packages/jest-haste-map/src/worker.js b/packages/jest-haste-map/src/worker.js
@@ -33,6 +33,7 @@ const formatError = (error: string | Error): SerializableError => {
   }
 
   return {
+    code: error.code || undefined,
     message: error.message,
     stack: error.stack,
     type: 'Error',

diff --git a/types/TestResult.js b/types/TestResult.js
@@ -62,6 +62,7 @@ export type CoverageMap = {|
 |};
 
 export type SerializableError = {|
+  code?: mixed,
   message: string,
   stack: ?string,
   type?: string,