Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make vscode-jest Official #2183

Closed
4 of 5 tasks
orta opened this issue Nov 29, 2016 · 6 comments
Closed
4 of 5 tasks

Make vscode-jest Official #2183

orta opened this issue Nov 29, 2016 · 6 comments

Comments

@orta
Copy link
Member

orta commented Nov 29, 2016

Make vscode-jest Official, and allow it to share the majority of the code with a potential nuclide version.

TODO

  • Decide on repo? (would this be a npm module as a lerna thing? @cpojer)
  • TypeScript -> Flow
  • Convert from mocha -> Jest
  • Start to decouple VS Code from the codebase. This means only Extension.ts is allowed to use import {workspace} from 'vscode'; as a bare minimum.
  • Try to remove hacks/string parsing that could be fixed by officially supporting things inside Jest
@cpojer
Copy link
Member

cpojer commented Nov 29, 2016

Awesome.

Let's put all of these into packages/ inside of Jest. If you can reserve the package names on npm and add me (cpojer) and the "fb" user to it, that will be great. We can then start publishing from within this repo. We may need to figure out some permissions but that shouldn't be that big of a deal :)

@orta
Copy link
Member Author

orta commented Nov 29, 2016

So deployment of vscode packages isn't done via npm, ( that's a whole thing) so we don't need to claim it for vscode-jest, and from the look of it, we don't need to from atom (from a quick look at a tutorial.)

So, unless you think it makes more sense to have a jest-editor-support package that they both rely on, which I'm amiable to, then we don't need to claim anything?

@cpojer
Copy link
Member

cpojer commented Nov 29, 2016

Oh that's interesting, I was unaware. I definitely think we should split everything up into a jest-editor-support package (or many) and then find a way to publish the vscode package. For atom, we should do exactly the same: push most of the code into the editor support package and the atom specific code into a separate package that we deploy via apm. Does that make sense?

@orta
Copy link
Member Author

orta commented Nov 29, 2016

Yep 👍

@orta
Copy link
Member Author

orta commented Dec 30, 2016

This is done 👍

@orta orta closed this as completed Dec 30, 2016
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants