Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate default reporter broken output #6311

Closed
aaronabramov opened this issue May 27, 2018 · 7 comments · May be fixed by #6524
Closed

Investigate default reporter broken output #6311

aaronabramov opened this issue May 27, 2018 · 7 comments · May be fixed by #6524
Labels

Comments

@aaronabramov
Copy link
Contributor

sometimes i see our concurrent reporter trying to print something to stdout/stderr while it's running tests and it results in broken output:
screen shot 2018-05-27 at 2 41 33 pm

we should try to log everything that gets printed and find that piece that breaks the output

@SimenB
Copy link
Member

SimenB commented May 27, 2018

Is it packages/jest-cli/src/__tests__/test_scheduler.test.js? It outputs extra summaries when running it:
image

@SimenB
Copy link
Member

SimenB commented May 27, 2018

Fix:

diff --git i/packages/jest-cli/src/__tests__/test_scheduler.test.js w/packages/jest-cli/src/__tests__/test_scheduler.test.js
index 6170d087..88aa761d 100644
--- i/packages/jest-cli/src/__tests__/test_scheduler.test.js
+++ w/packages/jest-cli/src/__tests__/test_scheduler.test.js
@@ -11,7 +11,7 @@
 import TestScheduler from '../test_scheduler';
 import SummaryReporter from '../reporters/summary_reporter';
 
-jest.mock('../reporters/default_reporter');
+jest.mock('../reporters/base_reporter');
 const mockSerialRunner = {
   isSerial: true,
   runTests: jest.fn(),

@aaronabramov
Copy link
Contributor Author

a saw it happening in other projects as well. i think ideally Jest should not allow any output break the reporter

@SimenB
Copy link
Member

SimenB commented Jun 18, 2018

We'll have to intercept process.std{out,err}.write then

SimenB added a commit to SimenB/jest that referenced this issue Jun 22, 2018
SimenB added a commit to SimenB/jest that referenced this issue Jun 22, 2018
SimenB added a commit to SimenB/jest that referenced this issue Sep 29, 2018
SimenB added a commit to SimenB/jest that referenced this issue Nov 8, 2018
SimenB added a commit to SimenB/jest that referenced this issue Nov 9, 2018
@github-actions
Copy link

This issue is stale because it has been open for 1 year with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the Stale label Feb 25, 2022
@SimenB
Copy link
Member

SimenB commented Feb 27, 2022

#7900 probably

@SimenB SimenB closed this as completed Feb 27, 2022
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants