Rename ProjectConfig.name to ProjectConfig.id #10051
Conversation
|
Hi @msurekci! Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
| @@ -35,7 +35,6 @@ exports[`--showConfig outputs config info and exits 1`] = ` | |||
| ], | |||
| "moduleNameMapper": [], | |||
| "modulePathIgnorePatterns": [], | |||
| "name": "[md5 hash]", | |||
There was a problem hiding this comment.
should id exist here now that I have renamed name to id?
| @@ -513,14 +513,6 @@ describe("doesn't bleed module file extensions resolution with multiple workers" | |||
|
|
|||
| expect(configs).toHaveLength(2); | |||
|
|
|||
| const [{name: name1}, {name: name2}] = configs; | |||
There was a problem hiding this comment.
keep these, but just call them id instead of name
There was a problem hiding this comment.
I initially did this, however id doesn't exist. I'm confused and need some help understanding why id is not present
| @@ -146,7 +146,7 @@ export type InitialOptions = Partial<{ | |||
| }; | |||
| modulePathIgnorePatterns: Array<string>; | |||
| modulePaths: Array<string>; | |||
| name: string; | |||
| id: string; | |||
@mohamedsgap No afraid, not. I believe the PR allows contributors to make changes. If you wish you can do so. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Fixes #10013
As far as I understand it is just a renaming of a property.
Little confused with the failing tests. I expect
nameto no longer exist as I have renamed it toidbut, I would have assumedidwould return in the--showConfigoutput. Some help in the right direction of what is expected would be greatly appreciated.Test plan