Update node in jest worker #10145
Closed
Update node in jest worker #10145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @hi-matbub! The assertion that fails is this one: https://github.com/facebook/jest/blob/1c2011dbce785ba05f006d1f6636dc378daa7329/scripts/buildUtils.js#L35-L39 It will need to special case -- Regarding the failing tests, feel free to ignore them. The Mercurial tests require specific versions (I don't even know which 😅) |
|
Thank you for the feedback @SimenB. I will get on this right away! |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The PR is in reference to #10142
Updates:
nodeversion for jest-worker to10.13Notes
I saw an AssertionError in the Node CI. Looked like a simple fix but I have not had much luck finding the exact line the needs updating.
While running tests I ran into 2 fails that I believe to be related prior to testing.. I have screen shotted them below.
Test plan
n/a