Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a note to the Exceptions section #10742

Merged
merged 2 commits into from Oct 30, 2020
Merged

Add a note to the Exceptions section #10742

merged 2 commits into from Oct 30, 2020

Conversation

g13n
Copy link
Contributor

@g13n g13n commented Oct 30, 2020

It looks like the documentation no longer mentions that the function needs to be wrapped otherwise the assertion will fail.

Summary

Test plan

It looks like the documentation no longer mentions that the function needs to be wrapped otherwise the assertion will fail.
@facebook-github-bot
Copy link
Contributor

Hi @g13n!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@SimenB
Copy link
Member

SimenB commented Oct 30, 2020

It looks like the documentation no longer mentions that the function
needs to be wrapped otherwise the assertion will fail.
@g13n
Copy link
Contributor Author

g13n commented Oct 30, 2020

@SimenB SimenB merged commit d554eb1 into jestjs:master Oct 30, 2020
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
@g13n g13n deleted the patch-1 branch June 30, 2021 10:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants