New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update type definitions for coverageThreshold #10893

Merged

SimenB merged 5 commits into jestjs:master from abouroubi:master

Dec 3, 2020

Contributor

abouroubi commented Nov 30, 2020

coverageThreshold now accepts custom properties

Summary

fixes #10884

Test plan


          chore: update type definitions for coverageThreshold

9ef2795

coverageThreshold now accepts custom properties

Contributor

facebook-github-bot commented Nov 30, 2020

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

abouroubi mentioned this pull request

Config types don't accept custom paths #10884

Closed

Contributor

facebook-github-bot commented Nov 30, 2020

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

facebook-github-bot added the cla signed label


          fix: 🐛 fix lint error

963549c

Contributor

facebook-github-bot commented Nov 30, 2020

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

3 similar comments

Contributor

facebook-github-bot commented Nov 30, 2020

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Contributor

facebook-github-bot commented Nov 30, 2020

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Contributor

facebook-github-bot commented Nov 30, 2020

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

SimenB requested changes

View reviewed changes

Member

SimenB left a comment

thanks! Could you add a type test (probably a new top level one for config) and a changelog entry?

Contributor

facebook-github-bot commented Nov 30, 2020

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

6 similar comments

Contributor

facebook-github-bot commented Dec 1, 2020

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Contributor

facebook-github-bot commented Dec 1, 2020

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Contributor

facebook-github-bot commented Dec 1, 2020

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Contributor

facebook-github-bot commented Dec 1, 2020

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Contributor

facebook-github-bot commented Dec 1, 2020

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Contributor

facebook-github-bot commented Dec 1, 2020

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Contributor Author

abouroubi commented Dec 1, 2020

thanks! Could you add a type test (probably a new top level one for config) and a changelog entry?

Yes ! I’ll check how to add tests.

Also, Is there a way to stop the bot from spamming 😅

Contributor

facebook-github-bot commented Dec 1, 2020

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Member

SimenB commented Dec 1, 2020

Also, Is there a way to stop the bot from spamming 😅

I'd love to know myself... Incredibly annoying. You could try opening up a new PR? 😛

Contributor

facebook-github-bot commented Dec 1, 2020

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!


          chore: use existing coverage threshold type

b236b62

Contributor Author

abouroubi commented Dec 1, 2020

@SimenB I checked the top level tests, but honestly I don't know how to test the Config object, can you provide some guidance ?

Member

SimenB commented Dec 1, 2020

Just expectType<Config.InitialOptions>({ coverageThresholds: {['some/path']: {blabla}} }) or something. Whatever it is you wanted to write which gave a type error previously 👍


          test: ✅ add tests for coverageThreshold types

532baaf

Contributor Author

abouroubi commented Dec 2, 2020

@SimenB well tried to add tests like you suggested, but apparently CI does not pass, the lib mlh-tsdis too obscure for me, I have no idea how I can fix the error.


          assignable

3a63b68

SimenB approved these changes

View reviewed changes

Member

SimenB left a comment

thanks!

SimenB merged commit 9e93de8 into jestjs:master

github-actions bot commented May 11, 2021

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

github-actions bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.