fix(jest-snapshot): @babel/core peer dependency warnings #10946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not adding changelog since this was only introduced in one of the commits mentioned in changelog |
ahnpnl
reviewed
Dec 13, 2020
|
@SimenB this gud? |
dog-dot
approved these changes
Feb 14, 2021
|
Can you rebase? |
jeysal
force-pushed
the
jest-snapshot-deps
branch
from
e634ff5
to
773b6cb
Compare
|
done |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #10931.
Not sure why
@babel/corewould need to be a peer dep, we only parse and traverse some JS with all syntax enabled.Test plan
idk if we can test this without a beta release