update fake timers example #10964
update fake timers example #10964
Conversation
A coworker had a rough time trying to figure out why timerGame wasn't executing There seemed to be a gap in the doc between mocking setTimeout and mentioning that it no longer runs immediately
|
Hi @neaumusic! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
I'm not sure that a code comment is the best way to clarify it, should it be made clearer in the opening docs? |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Seems the bot closed this instead of retargeting when we renamed |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
A coworker had a rough time trying to figure out why timerGame wasn't executing
There seemed to be a gap in the doc between mocking setTimeout and mentioning that it no longer runs immediately