Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Update dependencies for @jest/fake-timer #11170

Closed
wants to merge 1 commit into from

Conversation

HonzaMac
Copy link

@HonzaMac HonzaMac commented Mar 8, 2021

  • Upgrading @sinonjs/fake-timers to version v7

Fixes #11169.

Summary

Test plan

@facebook-github-bot
Copy link
Contributor

Hi @HonzaMac!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@SimenB
Copy link
Member

SimenB commented Mar 8, 2021

Thanks @HonzaMac! I haven't done this since the types of v7 are really bad. Should probably try to fix that though so we can update.

sinonjs/fake-timers#356 (comment)


CI is failing since you haven't updated the lockfile - just run yarn from the root of the repo (it'll still fail for the types, but everything else should pass (or at least run))

- Upgrading `@sinonjs/fake-timers` to version v7
@HonzaMac
Copy link
Author

HonzaMac commented Mar 8, 2021

@SimenB Thank you!
I've updated yarn.lock, but unless types are fixed, we can't proceed with this PR anyway.

@SimenB
Copy link
Member

SimenB commented Mar 8, 2021

@HonzaMac we have runtime errors as well that would be good to fix

@HonzaMac
Copy link
Author

HonzaMac commented Mar 9, 2021

Seems those runtime errors are due wrong typings. I will try to wrote those types.

@HonzaMac
Copy link
Author

@SimenB Thank you!

I had trouble running jest clone locally and specially to extend test suite to verify "refresh()" method.

You were faster! Thanks

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timers.refresh() method does not work using jest.advanceTimersByTime() method
3 participants