-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Clarify CLI param testPathIgnorePatterns usage #11304
Conversation
Hi @kevin-brotcke! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #11304 +/- ##
==========================================
- Coverage 64.19% 64.17% -0.02%
==========================================
Files 308 308
Lines 13528 13528
Branches 3297 3297
==========================================
- Hits 8684 8682 -2
- Misses 4131 4132 +1
- Partials 713 714 +1
Continue to review full report at Codecov.
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It took me way too long to figure out the correct way to pass multiple regexps as an array. Update the docs with more information and examples. Also clarify the testPathIgnorePatterns param accepts either a string or an array.
Thanks for reviewing. Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
It took me way too long to figure out the correct way to pass multiple regexps as an array. Update the docs with more information and examples.
Also clarify the testPathIgnorePatterns param accepts either a string or an array.
Test plan
Ran examples I added to docs in my local environment.