Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: "Wiener" isn't always a sausage #11312

Merged
merged 4 commits into from
Apr 22, 2021
Merged

Conversation

johnny353535
Copy link
Contributor

@johnny353535 johnny353535 commented Apr 19, 2021

Summary

"Wiener" doesn't mean sausage in this context, but rather "from Vienna". "Schnitzel" may be translated as "cutlet". "Wiener Würstchen" would be a sausage.

"Wiener" doesn't mean sausage in this context, but rather "from Vienna". "Schnitzel" may be translated as "cutlet"
@facebook-github-bot
Copy link
Contributor

Hi @johnny353535!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@johnny353535 johnny353535 changed the title "Wiener" isn't always a sausage docs: "Wiener" isn't always a sausage Apr 19, 2021
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair enough 😀

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you update the versioned docs so they are the same as well?

image

@SimenB SimenB merged commit b86e48a into jestjs:master Apr 22, 2021
@cpojer cpojer mentioned this pull request May 3, 2021
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants