Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Docusaurus beta, increase Netlify Nodejs memory #11516

Merged
merged 4 commits into from
Jun 3, 2021
Merged

Use Docusaurus beta, increase Netlify Nodejs memory #11516

merged 4 commits into from
Jun 3, 2021

Conversation

slorber
Copy link
Contributor

@slorber slorber commented Jun 3, 2021

Fix Netlify OOM with Docusaurus using Webpack 5 by using more memory, as the default setting may not be enough (Webpack 5 does more things than Webpack 4 so not too surprised it is required)

Fixes facebook/docusaurus#4843 reported by @SimenB

Note: large sites like ReactNative also have similar memory setting: facebook/react-native-website#2557

feed: ^4.2.2
fs-extra: ^9.1.0
fs-extra: ^10.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fs-extra v10 does not support node v10 like this repo does. not sure how much of a problem that is?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

root/node_modules/fs-extra remains in v9 in practice

@@ -63,6 +63,7 @@
"micromatch": "^4.0.4",
"mlh-tsd": "^0.14.1",
"mock-fs": "^4.4.1",
"netlify-plugin-cache": "^1.0.3",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be in website/package.json, no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using netlify with monorepos is sometimes a bit confusing. I find that putting netlify.toml and netlify plugins at the root is the simplest solution that works fine when monorepo only contains a single website

I just reverted the commit you already merged/reverted btw

@slorber
Copy link
Contributor Author

slorber commented Jun 3, 2021

@SimenB I don't understand why the CI fails, looks related to yarn install --immutable but I don't have the issue locally

➤ YN0028: │ The lockfile would have been modified by this install, which is explicitly forbidden.

@SimenB
Copy link
Member

SimenB commented Jun 3, 2021

rebase on master so you get #11515 as well

@slorber
Copy link
Contributor Author

slorber commented Jun 3, 2021

Thanks, btw didn't know about that --immutable, pretty sure used something like git diff for the same kind of thing in the past :D

@SimenB SimenB merged commit 155e7d0 into jestjs:master Jun 3, 2021
@SimenB
Copy link
Member

SimenB commented Jun 3, 2021

image

@github-actions
Copy link

github-actions bot commented Jul 4, 2021

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Netlify deploy using Webpack@5 OOMs
3 participants