Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed explicit type declarations #12038

Merged
merged 3 commits into from Nov 26, 2021
Merged

Removed explicit type declarations #12038

merged 3 commits into from Nov 26, 2021

Conversation

Biki-das
Copy link
Contributor

@Biki-das Biki-das commented Nov 4, 2021

Explicit types where they can be easily inferred may add unnecessary verbosity for variables or parameters initialized to a number, string, or boolean, so this PR furthers remove it

@codecov-commenter
Copy link

Codecov Report

Merging #12038 (c4e8b06) into main (95f4969) will not change coverage.
The diff coverage is 91.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #12038   +/-   ##
=======================================
  Coverage   68.77%   68.77%           
=======================================
  Files         324      324           
  Lines       16670    16670           
  Branches     4814     4814           
=======================================
  Hits        11465    11465           
  Misses       5172     5172           
  Partials       33       33           
Impacted Files Coverage Δ
packages/expect/src/jestMatchersObject.ts 85.71% <0.00%> (ø)
packages/expect/src/asymmetricMatchers.ts 83.05% <100.00%> (ø)
packages/expect/src/matchers.ts 97.86% <100.00%> (ø)
packages/jest-cli/src/init/generateConfigFile.ts 96.96% <100.00%> (ø)
packages/jest-cli/src/init/index.ts 87.50% <100.00%> (ø)
packages/jest-config/src/index.ts 20.00% <100.00%> (ø)
packages/jest-config/src/normalize.ts 89.11% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95f4969...c4e8b06. Read the comment docs.

@Biki-das
Copy link
Contributor Author

Biki-das commented Nov 6, 2021

@SimenB could you review this when you get some time?

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB SimenB merged commit 2a5e515 into jestjs:main Nov 26, 2021
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants