Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: doc fix "Rendering" -> "rendering" #12152

Merged
merged 1 commit into from Dec 20, 2021
Merged

Fix: doc fix "Rendering" -> "rendering" #12152

merged 1 commit into from Dec 20, 2021

Conversation

Biki-das
Copy link
Contributor

@Biki-das Biki-das commented Dec 15, 2021 •
edited

small document update, upper case letter was being used after the initialization of the sentence

@Biki-das Biki-das changed the title Fix : doc fix ,replacing "Rendering" --> Fix : doc fix ,replacing "Rendering" --> "rendering" Dec 15, 2021
@Biki-das
Copy link
Contributor Author

Biki-das commented Dec 15, 2021 •
edited

@SimenB please review,
Also i would like to forward my help, as a junior maintainer , i have seen only you managing the stuff in jest, there are many stale PR's and stuff that i can help to clean up and better assist you maintaining the repo, along with learning from you

SimenB
SimenB approved these changes Dec 20, 2021
View reviewed changes
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB SimenB changed the title Fix : doc fix ,replacing "Rendering" --> "rendering" Fix: doc fix "Rendering" -> "rendering" Dec 20, 2021
@SimenB SimenB merged commit 9969060 into jestjs:main Dec 20, 2021
@SimenB
Copy link
Member

SimenB commented Dec 20, 2021

Also i would like to forward my help, as a junior maintainer , i have seen only you managing the stuff in jest, there are many stale PR's and stuff that i can help to clean up and better assist you maintaining the repo, along with learning from you

Thanks for the offer! Unfortunately I have had little to no time for OSS since summer, and I don't see that changing anytime soon (although I might be able to spend some time over the holidays coming up). However, that also means I don't have the time to do any onboarding or some such either... But I'll keep this in mind whenever I have the time and energy to devote to OSS again! And thanks again for offering! 🙂

@Biki-das
Copy link
Contributor Author

Also i would like to forward my help, as a junior maintainer , i have seen only you managing the stuff in jest, there are many stale PR's and stuff that i can help to clean up and better assist you maintaining the repo, along with learning from you

Thanks for the offer! Unfortunately I have had little to no time for OSS since summer, and I don't see that changing anytime soon (although I might be able to spend some time over the holidays coming up). However, that also means I don't have the time to do any onboarding or some such either... But I'll keep this in mind whenever I have the time and energy to devote to OSS again! And thanks again for offering! 🙂

I understand in the meanwhile i will devote my time understanding the codebase more, and squashing more bugs , see you!

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SimenB SimenB SimenB approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Biki-das @SimenB @facebook-github-bot