Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(jest-reporters): remove useless conditional #13564

Merged
merged 1 commit into from
Nov 6, 2022
Merged

refactor(jest-reporters): remove useless conditional #13564

merged 1 commit into from
Nov 6, 2022

Conversation

Fdawgs
Copy link
Contributor

@Fdawgs Fdawgs commented Nov 6, 2022

Summary

Removes useless conditional, as the variable is already checked a few lines above on line 90:

https://github.com/facebook/jest/blob/bb28e7962b85caa861eb95431c52c7297947c981/packages/jest-reporters/src/SummaryReporter.ts#L90

Test plan

N/A

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch 👍

@SimenB SimenB merged commit 7c48c4c into jestjs:main Nov 6, 2022
@Fdawgs Fdawgs deleted the ref/jest-reporting branch November 6, 2022 10:00
@github-actions
Copy link

github-actions bot commented Dec 7, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants