refactor(jest-mock): clean up internal typings more #13575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrazauskas
commented
Nov 8, 2022
| @@ -1089,12 +1089,11 @@ export class ModuleMocker { | |||
| methodKey: K, | |||
| ): V extends ClassLike | FunctionLike ? Spied<V> : never; | |||
|
|
|||
| // eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types | |||
| spyOn<T extends object, K extends PropertyLikeKeys<T>>( | |||
| spyOn<T extends object>( | |||
There was a problem hiding this comment.
The overloads are now way more readable. Nice to look at them.
One more detail I am leaving for the future iterations. The return type of spyOn and _spyOnProperty methods is MockInstance, but the value wich is return has to be cast using as Mock. This is because of the return type of _makeComponent method. It comes from overloads which are causing some type issues. That needs more thinking. So I am leaving this for the future.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
spyOncurrent is missing a return type. Recent refactors made it possible to add the type and to removeeslint-disablecomment.The return type was the main focus. Few more details got tweaked own the way.
Test plan
TS build and type tests should pass.