Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jest-transform): ensure correct config is passed to preprocessors specified multiple times in transform #13770

Merged
merged 3 commits into from
Jan 15, 2023
Merged

fix(jest-transform): ensure correct config is passed to preprocessors specified multiple times in transform #13770

merged 3 commits into from
Jan 15, 2023

Conversation

coffeebeats
Copy link
Contributor

Fixes #13769.

Summary

Regarding the transform option of Jest configuration, it's not currently possible to use the same preprocessor with different configuration objects for different match patterns. This is because the latest entry in transform for a given preprocessor will always overwrite the configuration of earlier entries. See #13769 for more context.

Implementation

Instead of caching preprocessors and the corresponding configuration based solely on the preprocessor path, we can cache based on the match pattern + preprocessor path pair. While there are different ways of going about this, here I've updated transformCache to use a simple string concatenation of the file match pattern + preprocessor path for its keys. This ensures that the correct configuration can be identified.

Please let me know if you'd prefer an alternative means of solving this problem - I'm happy to adjust.

Test plan

I included a new unit test which validates this case. In addition to ensuring all current tests pass, please let me know if there's any other tests that would be useful to write.

@facebook-github-bot
Copy link
Contributor

Hi @coffeebeats!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@SimenB
Copy link
Member

SimenB commented Jan 14, 2023

ESLint caught something - you can run yarn lint-ts-files locally to see the error

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Multiple uses of a preprocessor in the transform option will have custom config overwritten
3 participants