Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jest-circus): Send test case results for todo type of tests #13915

Merged
merged 5 commits into from
Feb 23, 2023
Merged

fix(jest-circus): Send test case results for todo type of tests #13915

merged 5 commits into from
Feb 23, 2023

Conversation

akshitsinha
Copy link
Contributor

Summary

Makes Jest circus emit test-case-result event along with their path and results.
This fixes #12184 where custom reporters didn't call onTestCaseResult() for todo tests. Emitting test case results for test.todo also makes pathway for IDE extensions to show todo icon for todo tests using testCaseResult.status instead for skip or respective icon as they are currently.

image

@akshitsinha
Copy link
Contributor Author

akshitsinha commented Feb 15, 2023

Apparently this works fine without jasmine. Can someone help me out here as to why exactly this isn't working with jasmine?

image

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB SimenB merged commit 9d4efd1 into jestjs:main Feb 23, 2023
@akshitsinha akshitsinha deleted the todoReporterFix branch February 23, 2023 12:49
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Reporter.onTestCaseResult not called for test.todo in Jest 27
4 participants