Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent false test failures caused by promise rejections handled asynchronously #14110

Merged
merged 18 commits into from
Jun 21, 2023

Commits on Apr 25, 2023

  1. Add failing integration tests

    stekycz committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    91cb749 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bc66d54 View commit details
    Browse the repository at this point in the history
  3. Update changelog

    stekycz committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    67966d7 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    302e12d View commit details
    Browse the repository at this point in the history
  5. Wait until next event loop turn when there is a reason to wait for re…

    …jectionHandled event only
    
    Awaiting for the next turn is potentially conflicting with fake timers usage.
    stekycz committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    9efe383 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2023

  1. Configuration menu
    Copy the full SHA
    644b766 View commit details
    Browse the repository at this point in the history
  2. Update fake timers legacy test

    Legacy fake timers execute original setImmediate in its fake implementation. I believe removing that behaviour would cause more harm than failing the test here that seems to be synthetic anyway.
    stekycz committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    e564012 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fc973e2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f2592e5 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d7be001 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2023

  1. Configuration menu
    Copy the full SHA
    c639e85 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2023

  1. Configuration menu
    Copy the full SHA
    64ef973 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d7b963c View commit details
    Browse the repository at this point in the history

Commits on May 22, 2023

  1. Update comments

    stekycz committed May 22, 2023
    Configuration menu
    Copy the full SHA
    00ecc46 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b8d9c41 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2023

  1. Configuration menu
    Copy the full SHA
    5fd3805 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b412305 View commit details
    Browse the repository at this point in the history
  3. Fix tests for Jasmine

    stekycz committed May 26, 2023
    Configuration menu
    Copy the full SHA
    b775b19 View commit details
    Browse the repository at this point in the history