chore: upgrade node version #14460
chore: upgrade node version #14460
Conversation
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -12,7 +12,7 @@ jobs: | |||
| strategy: | |||
| fail-fast: false | |||
| matrix: | |||
| node-version: [14.x, 16.x, 18.x, 19.x, 20.x] | |||
| node-version: [16.x, 18.x, 20.x] | |||
There was a problem hiding this comment.
Old idea: perhaps it would make sense to run CI checks on 16.10 as well? This is the lowest supported version. The 16.x tag resolves to the latest version in the 16 series.
There was a problem hiding this comment.
hmm, yeah. that probably makes sense to do 👍 Separately from this PR, tho. Should do the same for the first versions of all node versions we claim support for
…t into chore-upgrade-node-version * 'chore-upgrade-node-version' of github.com:eryue0220/jest: Update CHANGELOG.md
|
A new error occurred that caused by the type declaration conflict, or we need to add work around? The |
| declare global { | ||
| // eslint-disable-next-line @typescript-eslint/no-namespace | ||
| namespace NodeJS { | ||
| interface Global { |
There was a problem hiding this comment.
this is removed in the node 16 types
There was a problem hiding this comment.
Awesome job and thank you.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Fix: #14442
Test plan