Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare website docs content for MDX v2 and Docusaurus v3 #14492

Merged
merged 3 commits into from
Sep 7, 2023

Conversation

slorber
Copy link
Contributor

@slorber slorber commented Sep 7, 2023

Summary

Preparation PR to make content compatible with MDX v2 (coming with Docusaurus v3).

Those docs are currently only compatible with MDX v1 (Docusaurus v2).

Now they are compatible with both MDX v1 and v2 (so Docusaurus v2 and v3), and the upgrade won't require to update them.

Follow-up PR that upgrades to Docusaurus v3 and MDX v2: #14463

Test plan

Deploy preview

@netlify
Copy link

netlify bot commented Sep 7, 2023

Deploy Preview for jestjs ready!

Name Link
🔨 Latest commit 1b6d376
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/64f9c9c906f67f000812fba0
😎 Deploy Preview https://deploy-preview-14492--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@slorber slorber changed the title Prepare content for MDX v2 Prepare website docs content for MDX v2 and Docusaurus v3 Sep 7, 2023
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks!

@@ -120,7 +120,7 @@ Clears all information stored in the [`mockFn.mock.calls`](#mockfnmockcalls), [`

The [`clearMocks`](configuration#clearmocks-boolean) configuration option is available to clear mocks automatically before each tests.

:::warning
:::danger
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:::danger
:::caution

I think that looks better

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, you wanted to that separately. makes sense! 😀

@SimenB SimenB merged commit d724d2b into jestjs:main Sep 7, 2023
79 of 91 checks passed
@github-actions
Copy link

github-actions bot commented Oct 8, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants