Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use glob@10 in build scripts #14512

Merged
merged 1 commit into from Sep 11, 2023
Merged

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Sep 11, 2023

Summary

Parts of #14509 that we can land now if CI is happy. While node 14 is no longer on their CI, we only use this part for building (i.e. not user facing). So if CI is happy, this is landable. And we already pull in glob@10 via rimraf

Test plan

Green CI

@netlify
Copy link

netlify bot commented Sep 11, 2023

Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 5f0227e
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/64ff225aa666b000084ff890
😎 Deploy Preview https://deploy-preview-14512--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SimenB SimenB merged commit 176b229 into jestjs:main Sep 11, 2023
90 of 91 checks passed
@SimenB SimenB deleted the glob-10-build branch September 11, 2023 15:18
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant