Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update upgrade to jest28 url to point to archive url #14988

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

peterdenham
Copy link
Contributor

@peterdenham peterdenham commented Mar 22, 2024

Summary

Existing error message relating to breaking changes in Jest 28 contains a link to the "Upgrading to Jest 28" docs page. This link currently points to a 404 page. This updates the link to the archived docs page.

Current link: https://jestjs.io/docs/28.x/upgrading-to-jest28#transformer
New link: https://jest-archive-august-2023.netlify.app/docs/28.x/upgrading-to-jest28#transformer

Test plan

I have a local test that was reproducing this error message. Attached screen recording shows the current error messaging and link, first. Then, I rerun the failing test using my locally compiled Jest from the PR, showing the corrected URL.

CleanShot 2024-03-21 at 21 49 13

Copy link

linux-foundation-easycla bot commented Mar 22, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link

netlify bot commented Mar 22, 2024

Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 05384ef
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/65fce94f4808100008eb2f5c
😎 Deploy Preview https://deploy-preview-14988--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@SimenB SimenB merged commit 71f0ba4 into jestjs:main Mar 26, 2024
73 checks passed
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants