Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: remove deprecated jest.genMockFromModule() #15042

Merged
merged 3 commits into from
Apr 29, 2024

Conversation

mrazauskas
Copy link
Contributor

Summary

This PR removes deprecated jest.genMockFromModule(), which was replaced with jest.createMockFromModule() in Jest 26 (see: #9962).

Test plan

Green CI.

Copy link

netlify bot commented Apr 28, 2024

Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit bdb55f9
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/662e68d358e83b00087675c6
😎 Deploy Preview https://deploy-preview-15042--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -231,28 +231,6 @@ describe('dependencyExtractor', () => {
);
});

it('should extract dependencies from `jest.genMockFromModule` calls', () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Identical jest.createMockFromModule test lives just under this one.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@SimenB SimenB merged commit 1bf56dd into jestjs:main Apr 29, 2024
84 checks passed
@mrazauskas mrazauskas deleted the remove-genMockFromModule branch April 29, 2024 10:43
@SimenB
Copy link
Member

SimenB commented May 12, 2024

Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants