-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add async function support to beforeEach and afterEach #1546
Conversation
Waiting for unit tests to run on Travis since everything fails locally. |
This is great! What about beforeAll/afterAll? What is wrong locally? |
I don't use them :P
70 tests fail like
Master fails too so I figured I'd just use Travis. |
Master is passing for me and on travis. Seems like an issue with your node version? |
You now can write: ``` beforeEach(async () => { await somethingAsync(); }); ```
Current coverage is 90.27% (diff: 100%)@@ master #1546 diff @@
==========================================
Files 28 28
Lines 1121 1121
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 1012 1012
Misses 109 109
Partials 0 0
|
thank you! |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
You now can write:
Fix #1256