Ignore dot dirs default #3935
Closed
Ignore dot dirs default #3935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3935 +/- ##
======================================
Coverage 58.1% 58.1%
======================================
Files 196 196
Lines 6752 6752
Branches 6 6
======================================
Hits 3923 3923
Misses 2826 2826
Partials 3 3
Continue to review full report at Codecov.
|
|
Thank you but I don't believe I'd like to set this as default behavior at this point. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3827
Summary
Makes jest ignore directories that start with a
.by default in addition to ignoringnode_modules. Ex:.cacheMotivation
When
$HOMEis the same as the application directory yarn will default to putting its cache directory at$APP_DIR/.cache/yarn/v1/...and Jest will pick up tests in dependencies.This happens to users trying to use Jest with Heroku CI, where
$HOMEis/app. Currently any user using both yarn and jest will hit this issue in that environment.Test plan
yarn test