Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't skip configured matchers for exact file names #5582

Merged
merged 3 commits into from
Feb 16, 2018

Conversation

rickhanlonii
Copy link
Member

Summary

This PR partially reverts #3882 so that we don't skip unmatched test paths from CLI

See previous:

Closes #5527

Test plan

I left the integrations tests that were there but reworded them and added a case

Without this change, the second case will fail

@codecov-io
Copy link

codecov-io commented Feb 16, 2018

Codecov Report

Merging #5582 into master will increase coverage by 0.09%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5582      +/-   ##
==========================================
+ Coverage   60.63%   60.73%   +0.09%     
==========================================
  Files         213      213              
  Lines        7311     7299      -12     
  Branches        3        3              
==========================================
  Hits         4433     4433              
+ Misses       2877     2865      -12     
  Partials        1        1
Impacted Files Coverage Δ
packages/jest-cli/src/search_source.js 45.83% <0%> (+6.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 966aab6...0c60211. Read the comment docs.

@cpojer
Copy link
Member

cpojer commented Feb 16, 2018

CI is unhappy

@rickhanlonii
Copy link
Member Author

Thanks @cpojer, fixed

@cpojer cpojer merged commit 950b2e7 into jestjs:master Feb 16, 2018
@cpojer
Copy link
Member

cpojer commented Feb 16, 2018

Thanks for doing this!

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Single file testing doesn't work correctly after migration to Jest 22
4 participants