Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes regenerator go through custom resolvers as well #6017

Merged
merged 2 commits into from Apr 17, 2018

Conversation

arcanis
Copy link
Contributor

@arcanis arcanis commented Apr 17, 2018

Summary

This diff is just a followup to #5976 - I missed this call because it uses findNodeModule instead of resolve like the others (because it doesn't want to throw if the result cannot be found).

Test plan

Tests should continue to pass.

@SimenB
Copy link
Member

SimenB commented Apr 17, 2018

Possible with a test (or integration test) here?

@codecov-io
Copy link

codecov-io commented Apr 17, 2018

Codecov Report

Merging #6017 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #6017   +/-   ##
======================================
  Coverage    64.3%   64.3%           
======================================
  Files         217     217           
  Lines        8317    8317           
  Branches        3       4    +1     
======================================
  Hits         5348    5348           
  Misses       2968    2968           
  Partials        1       1
Impacted Files Coverage Δ
packages/jest-config/src/normalize.js 94.14% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02e1c66...755e5c9. Read the comment docs.

@arcanis
Copy link
Contributor Author

arcanis commented Apr 17, 2018

@SimenB here it is ! 🙂

@arcanis arcanis merged commit 43e67da into master Apr 17, 2018
@SimenB SimenB deleted the config-resolver-regenerator branch April 17, 2018 17:49
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants