Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add jest-junit #6322

Merged
merged 4 commits into from
May 29, 2018
Merged

ci: add jest-junit #6322

merged 4 commits into from
May 29, 2018

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented May 27, 2018

Summary

In theory should give us a nice dash of test status: https://circleci.com/docs/2.0/collect-test-data/#jest

Test plan

Take a look at fancy dashboard?

@SimenB
Copy link
Member Author

SimenB commented May 27, 2018

Sorta ref #3536

@SimenB
Copy link
Member Author

SimenB commented May 27, 2018

Huh, didn't work. Maybe https://circleci.com/docs/2.0/configuration-reference/#store_test_results?

I'll look into it tomorrow or something, sleep time now

@codecov-io
Copy link

codecov-io commented May 28, 2018

Codecov Report

Merging #6322 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6322   +/-   ##
=======================================
  Coverage   63.89%   63.89%           
=======================================
  Files         228      228           
  Lines        8705     8705           
  Branches        3        3           
=======================================
  Hits         5562     5562           
  Misses       3142     3142           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5ed1a5...609bf52. Read the comment docs.

@cpojer
Copy link
Member

cpojer commented May 28, 2018

lol, love how there is documentation for how to use Jest that we are using on.. Jest.

@aaronabramov
Copy link
Contributor

if that works that'll be my new favorite feature!

@SimenB
Copy link
Member Author

SimenB commented May 28, 2018

Should do the same for eslint, I guess: https://www.viget.com/articles/using-junit-on-circleci-2-0-with-jest-and-eslint/

maybe even flow? idk if they have a junit report

@palmerj3
Copy link
Contributor

@SimenB it looks like perhaps circle-ci's docs are not correct for the jest section? In the store_test_results section it shows that the xml file needs to be named results.xml. So perhaps if you rename it from js-test-results.xml to results.xml it will pick it up.

@SimenB
Copy link
Member Author

SimenB commented May 28, 2018

image

https://circleci.com/build-insights/gh/facebook/jest/master

I guess that last one will be populated once we merge this to master

@SimenB SimenB merged commit 86c91d5 into jestjs:master May 29, 2018
@SimenB SimenB deleted the jest-junit branch May 29, 2018 09:22
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants