Fix ci #6356
Fix ci #6356
Conversation
|
@aaronabramov could you do a sanity check on the snapshot update? I think it's sane. Please merge if it is, I'm getting super spammed by circle with failures :P |
| @@ -13,8 +13,6 @@ finish_describe_definition: describe | |||
| run_start | |||
| run_describe_start: ROOT_DESCRIBE_BLOCK | |||
| run_describe_start: describe | |||
| hook_start: beforeAll | |||
| hook_success: beforeAll | |||
There was a problem hiding this comment.
These hooks shouldn't be removed, don't they?
The describe block doesn't have any skipped or focused tests:
https://github.com/facebook/jest/blob/644dd0d6335651794e2f34ec73e7c82c0bc050d2/packages/jest-circus/src/__tests__/after_all-test.js#L56-L66
There was a problem hiding this comment.
Oh, I missed the outer hooks hidden by the diff. All good!
There was a problem hiding this comment.
we should definitely add some intentation to snapshots! :)
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Should fix the failing tests on CI.
Updated snapshot cuz #6234, and re-added skipCircus cuz #6339
Test plan
CI