Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependency clash test modified in #6104 #7208

Merged
merged 1 commit into from
Oct 18, 2018

Conversation

rubennorte
Copy link
Contributor

Summary

That test was supposed to test the interaction between Haste modules and installed node_modules, so changing it to use relative paths made it useless. This fixes it by using hasteImplModulePath to convert it into a Haste module.

Test plan

Just ran the test.

@SimenB
Copy link
Member

SimenB commented Oct 18, 2018

Thanks for taking a look! This test still fails on the babel 7 branch though (after changing to @babel/traverse), as babel traverse has dropped the invariant dependency (babel/babel@2854a18). Do you think it's worth it to find some module that uses it? The test as is is pretty brittle as it depends on an implementation detail of a third party module.

@rubennorte
Copy link
Contributor Author

@SimenB, I understand now. I'll update it so it's isolated from that.

@rubennorte rubennorte force-pushed the fix-dependency-clash-test branch 2 times, most recently from e5c4502 to 70630fc Compare October 18, 2018 14:47
@rubennorte rubennorte merged commit a12806e into jestjs:master Oct 18, 2018
@rubennorte rubennorte deleted the fix-dependency-clash-test branch October 18, 2018 16:11
@SimenB
Copy link
Member

SimenB commented Oct 18, 2018

Merged this into babel 7, and it now passes. Thank you!

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants