Move from "process.exit" to "exit" #7327
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
@JLHwung hey, could you rebase this? 🙏 |
This is a follow-up to jestjs#5313
|
@SimenB Rebased and thanks for reminder. Nearly forgot this patch. 🤦♂️ |
|
This seems to break node 6, not sure why... I reverted for now, do you think you can open up a new PR and check that node 6 passes? |
Hmm, interesting. I will investigate the issue later this day. According to CircleCI, test also breaks on Node.js 11 for the same reason of Node.js 6. I doubt that if the |
|
that one's unrelated |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Follow up to #5313.
Test plan
Test failure seems unrelated.