standardize filenames in e2e #7471

GGonryun · 2018-12-05T20:45:09Z

Summary

This Pull Request helps standardizes file names with Facebook's naming conventions as outlined in issue #4969.

The following folders inside of ./e2e/ and their corresponding files, tests, or snapshots have been modified and checked:

auto-clear-mocks
auto-reset-mocks
auto-restore-mocks
babel-plugin-jest-hoist
bad-source-map
before-all-filtered
browser-support
clear-cache

The folder's corresponding tests can be located in ./e2e/__tests__/<folder_name>.test.js.
The folder's corresponding snapshots can be located in ./e2e/__tests__/__snapshots__/.

Test plan

executed yarn run clean-all and yarn install and yarn jest.
yarn jest yields no failures and similar results when compared to master.

thymikee · 2018-12-05T20:54:27Z

I don't think it's necessary to change these, but if you must, don't change to underscore_case – when in doubt use camelCase.

Feel free to take jest-runner and jest-runtime :)

GGonryun · 2018-12-05T21:03:48Z

I don't think it's necessary to change these, but if you must, don't change to underscore_case – when in doubt use camelCase.

Sorry about that! Thank you for the additional clarification

Feel free to take jest-runner and jest-runtime :)

Thank you! Should I be adding these to a new PR each or just add them to this one?

thymikee · 2018-12-05T21:05:07Z

Feel free to do it in one shot :)

…ource-map

thymikee · 2018-12-06T05:36:28Z

Ouch, I forgot about this one #7464
So please just scope this PR to e2e, sorry for confusion

GGonryun · 2018-12-06T06:39:44Z

@thymikee I'm a bit confused on how to undo my changes for jest-runtime and jest-runner. Do I reset back to the commit 455cedc and then continue with e2e from there after I rebase?

thank you for all the assistance! 😄

thymikee · 2018-12-06T09:33:09Z

You can throw away last commit, e.g by
git reset --hard 1284004

…ource-map

…files

…he' and their corresponding test files

* Add issue template labels * Lint

#7335)

…ource-map

GGonryun · 2019-01-09T07:38:45Z

I believe the e2e folder is done now. :)

Should I open a new PR for the other folders which need standardizing?

SimenB · 2019-01-09T08:43:41Z

This is fantastic, thank you so much for tackling it!

SimenB · 2019-01-09T08:44:02Z

@thymikee mind merging if it looks alright to you?

thymikee

Looking good! Left some final comments. Plus, looks like these files were renamed wrongly (GitHub makes it impossible to comment on renamed files, shame):

e2e/testNamePattern_skipped/package.json → e2e/test-name-pattern/package.json
e2e/testNamePattern/package.json → e2e/test-name-pattern-skipped/package.json

thymikee · 2019-01-09T09:51:30Z

e2e/transform/babel-jest/package.json

@@ -5,10 +5,10 @@
  "jest": {
    "collectCoverageOnlyFrom": {
      "<rootDir>/this-directory-is-covered/Covered.js": true,


Is this left with capital case on purpose? I've seen at least one more similar case (with (...)/Covered.js), so make sure to adjust that as well if you change that

I did miss these files, sorry! I also deleted the left over files named .e2e/transform/babel-jest/this-directory-is-covered/ExcludedFromCoverage.js and ./e2e/transform/no-babel-jest/this-directory-is-covered/ExcludedFromCoverage.js in the same location

e2e/transform/multiple-transformers/package.json

…ttern-temp/package.json

…ipped/package.json

…ttern.package.json

…rn/package.json

…ipped/package.json

…ource-map

… into standardize/bad-source-map

GGonryun · 2019-01-10T04:32:50Z

Sorry about that last mess of commits, I was trying to change the two file names and couldn't get git to recognize the swap, is it because the two files are identical?

e2e/transform-linked-modules/package.json

e2e/transform/custom-instrumenting-preprocessor/package.json

e2e/transform/babel-jest/this-directory-is-covered/excludedFromCoverage.js

thymikee · 2019-01-10T09:04:29Z

Thanks for staying with us on that, appreciated!

* standardizing file names to fit facebook standards * updating filenames to better fit facebook standards * standardizing jest-runner filenames to fit facebook standards * standardizing file names in /e2e/before-all-filtered * resolving naming discrepencies inside of files * standardizing filenames in e2e/before-each-queue and corresponding tests * standardizing several tests in ./e2e/__test__/ * standardizing filenames for babel-plugin-jest-hoist and related test files * standardizing file-names for folders 'browser-support' and 'clear-cache' and their corresponding test files * resolving issue with karma referencing non-standard browserTest * resolving issue with karma referencing non-standard browserTest filename * standardizing file names to fit facebook standards * updating filenames to better fit facebook standards * Add issue template labels (jestjs#7470) * Add issue template labels * Lint * standardizing jest-runner filenames to fit facebook standards * allow `bail` setting to control when to bail out of a failing test run (jestjs#7335) * standardizing file names in /e2e/before-all-filtered * resolving naming discrepencies inside of files * standardizing filenames in e2e/before-each-queue and corresponding tests * standardizing several tests in ./e2e/__test__/ * standardizing filenames for babel-plugin-jest-hoist and related test files * standardizing file-names for folders 'browser-support' and 'clear-cache' and their corresponding test files * resolving issue with karma referencing non-standard browserTest * resolving issue with karma referencing non-standard browserTest filename * standardizing file names in e2e/__test__ * standardizing file names in compare-dom-nodes * standardizing file names for coverage-report and coverage-remap * updating case sensitive filenames * renaming files to fit facebook standards * adding case sensitive file changes * resolving dependency issues after renaming case sensitive files. * standardizing file names to fit facebook standards * adjusting file names and snapshots to fit facebook standards * adjusting file names to fit facebook standards * resolves bug with nodeAssertionError not being found by test suite * changing references to match file name * changing file name to check test-jest-circus * readding a previously deleted snapshot * Update e2e/bad-source-map/__tests__/badSourceMap.js comment to reflect new file name Co-Authored-By: GGonryun <amodestduck@gmail.com> * improving file naming conventions letters g & j * changing filename to fit facebook standards * renaming filenames to fit facebook standards for 'L' * renaming filenames to fit facebook standards for 'M' * renaming filenames to fit facebook standards for 'N' * resolving leftover merge conflicts * reverting error in naming by changing filename back to uppercase * renaming filenames 'O' to fit facebook standards. * renaming filenames 'P' to fit facebook standards. * renaming filenames 'R' to fit facebook standards. * renaming filenames 'S' to fit facebook standards. * changing regex to match temporary folder name * renaming filenames 'T' to fit facebook standards. * renaming filenames 'U' to fit facebook standards. * renaming filenames 'V' to fit facebook standards. * renaming filenames 'W' to fit facebook standards. * updating snapshots to reflect standardized file names * Rename e2e/test-name-pattern-skipped/package.json to e2e/test-name-pattern-temp/package.json * Rename e2e/test-name-pattern/package.json to e2e/test-name-pattern-skipped/package.json * Rename e2e/test-name-pattern-skipped/package.json to e2e/test-name-pattern.package.json * Rename e2e/test-name-pattern-temp/package.json to e2e/test-name-pattern/package.json * Rename e2e/test-name-pattern.package.json to e2e/test-name-pattern-skipped/package.json * removing left over files and adjusting file names previously missed * deleting more leftover files

github-actions · 2021-05-12T04:08:49Z

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

standardizing file names to fit facebook standards

9cca3e5

facebook-github-bot added the cla signed label Dec 5, 2018

updating filenames to better fit facebook standards

455cedc

GGonryun changed the title ~~standardize filenames in e2e/bad-source-map~~ standardize filenames in e2e and packages Dec 5, 2018

GGonryun added 2 commits December 5, 2018 15:06

Merge remote-tracking branch 'upstream/master' into standardize/bad-s…

1284004

…ource-map

standardizing jest-runner filenames to fit facebook standards

35777a4

GGonryun changed the title ~~standardize filenames in e2e and packages~~ standardize filenames in e2e/bad-source-map and packages/jest-runner and packages/jest-runtime Dec 6, 2018

Merge remote-tracking branch 'upstream/master' into standardize/bad-s…

9d4c6b2

…ource-map

GGonryun changed the title ~~standardize filenames in e2e/bad-source-map and packages/jest-runner and packages/jest-runtime~~ standardize filenames in e2e Dec 6, 2018

GGonryun and others added 15 commits December 6, 2018 12:39

standardizing file names in /e2e/before-all-filtered

91564fd

resolving naming discrepencies inside of files

7094578

standardizing filenames in e2e/before-each-queue and corresponding tests

877fdd3

standardizing several tests in ./e2e/__test__/

bf3add4

standardizing filenames for babel-plugin-jest-hoist and related test …

adb8e94

…files

standardizing file-names for folders 'browser-support' and 'clear-cac…

997cb1d

…he' and their corresponding test files

resolving issue with karma referencing non-standard browserTest

da4f857

resolving issue with karma referencing non-standard browserTest filename

08c133d

fixing typo

e28719e

standardizing file names to fit facebook standards

7abaa4f

updating filenames to better fit facebook standards

b9c1a24

Add issue template labels (#7470)

82e248f

* Add issue template labels * Lint

standardizing jest-runner filenames to fit facebook standards

cf5c278

allow bail setting to control when to bail out of a failing test run (

a22f210

#7335)

standardizing file names in /e2e/before-all-filtered

2dc4507

GGonryun added 9 commits January 8, 2019 09:56

renaming filenames 'R' to fit facebook standards.

319d43d

Merge remote-tracking branch 'upstream/master' into standardize/bad-s…

ad232d3

…ource-map

renaming filenames 'S' to fit facebook standards.

e17f8ec

changing regex to match temporary folder name

ca607e3

renaming filenames 'T' to fit facebook standards.

1e7dba1

renaming filenames 'U' to fit facebook standards.

689f424

renaming filenames 'V' to fit facebook standards.

79fbd8e

renaming filenames 'W' to fit facebook standards.

8771cd8

updating snapshots to reflect standardized file names

7ef73d7

thymikee requested changes Jan 9, 2019

View reviewed changes

GGonryun added 7 commits January 9, 2019 19:36

Rename e2e/test-name-pattern-skipped/package.json to e2e/test-name-pa…

d6655ea

…ttern-temp/package.json

Rename e2e/test-name-pattern/package.json to e2e/test-name-pattern-sk…

755daf3

…ipped/package.json

Rename e2e/test-name-pattern-skipped/package.json to e2e/test-name-pa…

be3fef3

…ttern.package.json

Rename e2e/test-name-pattern-temp/package.json to e2e/test-name-patte…

1f5c30f

…rn/package.json

Rename e2e/test-name-pattern.package.json to e2e/test-name-pattern-sk…

6ba6c8f

…ipped/package.json

Merge remote-tracking branch 'upstream/master' into standardize/bad-s…

e94bbe8

…ource-map

Merge branch 'standardize/bad-source-map' of github.com:GGonryun/jest…

f6db9ce

… into standardize/bad-source-map

removing left over files and adjusting file names previously missed

373b417

thymikee reviewed Jan 10, 2019

View reviewed changes

e2e/transform-linked-modules/package.json Show resolved Hide resolved

e2e/transform/custom-instrumenting-preprocessor/package.json Show resolved Hide resolved

e2e/transform/babel-jest/this-directory-is-covered/excludedFromCoverage.js Show resolved Hide resolved

deleting more leftover files

c687f6c

thymikee approved these changes Jan 10, 2019

View reviewed changes

thymikee merged commit 5f4e5cd into jestjs:master Jan 10, 2019

github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

standardize filenames in e2e #7471

standardize filenames in e2e #7471

GGonryun commented Dec 5, 2018 •

edited

Loading

thymikee commented Dec 5, 2018 •

edited

Loading

GGonryun commented Dec 5, 2018 •

edited

Loading

thymikee commented Dec 5, 2018

thymikee commented Dec 6, 2018

GGonryun commented Dec 6, 2018

thymikee commented Dec 6, 2018

GGonryun commented Jan 9, 2019

SimenB commented Jan 9, 2019

SimenB commented Jan 9, 2019

thymikee left a comment

thymikee Jan 9, 2019 •

edited

Loading

GGonryun Jan 10, 2019

GGonryun commented Jan 10, 2019

thymikee commented Jan 10, 2019

github-actions bot commented May 12, 2021

standardize filenames in e2e #7471

standardize filenames in e2e #7471

Conversation

GGonryun commented Dec 5, 2018 • edited Loading

Summary

Test plan

thymikee commented Dec 5, 2018 • edited Loading

GGonryun commented Dec 5, 2018 • edited Loading

thymikee commented Dec 5, 2018

thymikee commented Dec 6, 2018

GGonryun commented Dec 6, 2018

thymikee commented Dec 6, 2018

GGonryun commented Jan 9, 2019

SimenB commented Jan 9, 2019

SimenB commented Jan 9, 2019

thymikee left a comment

Choose a reason for hiding this comment

thymikee Jan 9, 2019 • edited Loading

Choose a reason for hiding this comment

GGonryun Jan 10, 2019

Choose a reason for hiding this comment

GGonryun commented Jan 10, 2019

thymikee commented Jan 10, 2019

github-actions bot commented May 12, 2021

GGonryun commented Dec 5, 2018 •

edited

Loading

thymikee commented Dec 5, 2018 •

edited

Loading

GGonryun commented Dec 5, 2018 •

edited

Loading

thymikee Jan 9, 2019 •

edited

Loading