Run code transforms over global{Setup,Teardown}
#7562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
commented
Dec 29, 2018
| import type {GlobalConfig} from 'types/Config'; | ||
| import type {Test} from 'types/TestRunner'; | ||
|
|
||
| import {extname, resolve} from 'path'; | ||
| import pEachSeries from 'p-each-series'; |
There was a problem hiding this comment.
using p-each-series allows us to make sure one require hook does not interfere with another
SimenB
commented
Dec 29, 2018
SimenB
commented
Dec 29, 2018
| import type {GlobalConfig} from 'types/Config'; | ||
| import type {Test} from 'types/TestRunner'; | ||
|
|
||
| import {extname, resolve} from 'path'; | ||
| import pEachSeries from 'p-each-series'; | ||
| import {addHook} from 'pirates'; |
There was a problem hiding this comment.
pirates is what babel-register uses
SimenB
force-pushed
the
transform-global-setup-teardown
branch
3 times, most recently
from
65a50f8
to
53e8f54
Compare
Codecov Report
@@ Coverage Diff @@
## master #7562 +/- ##
==========================================
- Coverage 68.28% 67.93% -0.36%
==========================================
Files 250 248 -2
Lines 9627 9503 -124
Branches 5 5
==========================================
- Hits 6574 6456 -118
+ Misses 3051 3045 -6
Partials 2 2
Continue to review full report at Codecov.
|
jeysal
suggested changes
Dec 31, 2018
SimenB
force-pushed
the
transform-global-setup-teardown
branch
from
da9c958
to
655d16e
Compare
SimenB
commented
Dec 31, 2018
jeysal
approved these changes
Jan 1, 2019
SimenB
force-pushed
the
transform-global-setup-teardown
branch
from
655d16e
to
8b3b505
Compare
SimenB
force-pushed
the
transform-global-setup-teardown
branch
from
8b3b505
to
650a23e
Compare
|
This doesn't work with "testEnvironment" |
captain-yossarian
pushed a commit
to captain-yossarian/jest
that referenced
this pull request
Jul 18, 2019
captain-yossarian
pushed a commit
to captain-yossarian/jest
that referenced
this pull request
Jul 18, 2019
This was referenced Jul 25, 2019
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5164. A caveat is that this can not transpile stuff in
node_modules. This is because in order to transpile using e.g.babel-jest, we would need to loadbabel-jest, which means we cannot transpile it.We could try to do static analysis on the transformer modules defined in the config and create a dependency tree of the only files we won't transform, but I'm not sure if it's worth it (or possible). Stuff in
node_modulesshould be runnable in node either way.EDIT: If people want, we can disable
node-modulesignoring, and try to catch errors during transform. By default, Jest hastransformIgnorePatternonnode_modules, so shouldn't make a huge differenceTest plan
I added a flow annotation to an existing test to show the transform happens.