Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog: JavaScript Unit Testing Performance #790

Closed
wants to merge 2 commits into from
Closed

Conversation

cpojer
Copy link
Member

@cpojer cpojer commented Mar 11, 2016

First blog post, yay!

@@ -18,7 +18,6 @@ Check out the [Getting Started](http://facebook.github.io/jest/docs/getting-star
<generated_api_start />
#### The `jest` object

- `jest.addMatchers(matchers)`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sneaky!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, the README is updated by the publish script. This was already removed in API.md in a previous commit but I didn't push the website.

@vjeux
Copy link
Contributor

vjeux commented Mar 11, 2016

lgtm

@cpojer
Copy link
Member Author

cpojer commented Mar 11, 2016

@facebook-github-bot shipit

@facebook-github-bot
Copy link
Contributor

Thanks for importing. If you are an FB employee go to Phabricator to review.

@cpojer
Copy link
Member Author

cpojer commented Mar 11, 2016

@facebook-github-bot import

@facebook-github-bot
Copy link
Contributor

Thanks for importing. If you are an FB employee go to Phabricator to review.

@@ -920,6 +920,15 @@ div[data-twttr-id] iframe {
opacity: 1;
}

/** Blog Images **/
img[alt="perf-basic-scheduling"], img[alt="perf-improved-scheduling"] {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe make this a global style for within posts?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll update this for future blog posts. I don't think I want all the images have the same size. Unfortunately our version of markdown in Marked.js doesn't support specifying the width/height and <img /> tags don't work for some reason :) this was a quick hack, I guess :)

@ghost ghost closed this in f108912 Mar 11, 2016
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2021
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants