Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: handle non-iterable arrays in test environment #7993

Closed
wants to merge 2 commits into from

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Feb 26, 2019

Summary

Fixes #3879. I absolutely hate this solution. Maybe we should figure out a plan which allows us to run the test environment outside of the user sandbox? Would allow us to ditch the babel plugin, which is turning into a monster

Test plan

The test that was never run will now run, and hopefully pass

@SimenB
Copy link
Member Author

SimenB commented Feb 26, 2019

Doesn't even work :(

Seems I gave up last time: #4630. And the test is purposefully ignored

@rubennorte
Copy link
Contributor

Maybe we should figure out a plan which allows us to run the test environment outside of the user sandbox?

Totally. We've had other issues related to this and running the runner code in a different environment and then just share its globals with the test environment would probably solve them all.

@SimenB
Copy link
Member Author

SimenB commented Feb 28, 2019

@aaronabramov tried that in #3880, not sure why he aborted the attempt? Some side channel talk with @cpojer perhaps? I think @mjesun attempted it at some point as well.

I'll write it down for the summit in a few weeks, maybe we can figure out a way forward then

@mjesun
Copy link
Contributor

mjesun commented Feb 28, 2019

The information I had was that jest-circus will fix all of these, by properly running each thing in the right place.

@SimenB
Copy link
Member Author

SimenB commented Feb 28, 2019

jest-circus runs inside of the sandbox: https://github.com/facebook/jest/blob/5d2d46f1597e2880aeca4126947d7390cc6ff827/packages/jest-circus/src/legacy-code-todo-rewrite/jestAdapter.ts#L27

@github-actions
Copy link

github-actions bot commented Sep 8, 2022

This PR is stale because it has been open 1 year with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label Sep 8, 2022
@github-actions
Copy link

github-actions bot commented Oct 8, 2022

This PR was closed because it has been stalled for 30 days with no activity. Please open a new PR if the issue is still relevant, linking to this one.

@github-actions github-actions bot closed this Oct 8, 2022
@github-actions
Copy link

github-actions bot commented Nov 8, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Array.prototype[Symbol.iterator] = null stalls the process
4 participants