Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clone to new test environment options while create test environments #8420

Closed
wants to merge 3 commits into from

Conversation

lh0x00
Copy link
Contributor

@lh0x00 lh0x00 commented May 5, 2019

Resolved #8393 #5223

In test runner, when a test environment creates a new instance it using ref object of testEnvironmentOptions and if in the process have an action to affect object testEnvironmentOptions will affect too.

To fix it, we will clone an object testEnvironmentOptions in a test environment.

@lh0x00
Copy link
Contributor Author

lh0x00 commented May 5, 2019

@jeysal So I use Object.create to clone testEnvironmentOptions because deep clone in this case maybe don't necessary and it just made complexly! It's OK?

@lh0x00 lh0x00 closed this May 5, 2019
@lh0x00 lh0x00 deleted the bugfix/Issue-8393-5223 branch May 5, 2019 15:37
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSDOM virtualConsole environment option defunct in parallel mode
2 participants