Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: npmignore tsconfig.* files. #8641

Merged
merged 2 commits into from
Jul 4, 2019
Merged

Chore: npmignore tsconfig.* files. #8641

merged 2 commits into from
Jul 4, 2019

Conversation

StringEpsilon
Copy link
Contributor

Summary

Removes unnecessary files from build output / resulting package archive. Reduces install size.

Fixes #8639

Test plan

Build packages, check resulting archives for tsconfig.json and tsconfig.tsbuildinfo

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@codecov-io
Copy link

codecov-io commented Jul 4, 2019

Codecov Report

Merging #8641 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #8641   +/-   ##
======================================
  Coverage    63.4%   63.4%           
======================================
  Files         274     274           
  Lines       11342   11342           
  Branches     2770    2771    +1     
======================================
  Hits         7191    7191           
  Misses       3534    3534           
  Partials      617     617

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b64bb4...937a74b. Read the comment docs.

@thymikee thymikee requested a review from SimenB July 4, 2019 07:04
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

.npmignore Show resolved Hide resolved
@StringEpsilon
Copy link
Contributor Author

I signed the CLA. Not sure why the bot didn't update.

@SimenB SimenB merged commit 1749aea into jestjs:master Jul 4, 2019
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove TypeScript config and build info files from npm
5 participants