Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Jest work with AngularJS tutorial #8828

Merged
merged 3 commits into from
Aug 18, 2019
Merged

add Jest work with AngularJS tutorial #8828

merged 3 commits into from
Aug 18, 2019

Conversation

dwatow
Copy link
Contributor

@dwatow dwatow commented Aug 15, 2019

Summary

At this time, using AngularJS is different from the past. Many articles are not mentioned, including AngularJS 1.5+ component, using ES6 syntax, using webpack and installing Jest and related suites, where angularjs-jest in Jest greatly reduces the initial process of angularjs.mock.module and angularjs.mock.inject.
In my article, there are clear guidelines to help you use Jest to maintain an AngularJS test project.

Test plan

npm install
npm run test

run jest

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@dwatow
Copy link
Contributor Author

dwatow commented Aug 15, 2019 via email

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@jeysal
Copy link
Contributor

jeysal commented Aug 15, 2019

Thanks @dwatow! I can only judge the quality of the linked article by the code snippets and Google Translate, but it looks similar to the other articles linked. @SimenB is it possible to add this only to the Simplified Chinese docs? I have no idea how the docs i18n even works.

@SimenB
Copy link
Member

SimenB commented Aug 16, 2019

I don't think so. Doesn't hurt to have it in the main docs tho. I think?

@jeysal
Copy link
Contributor

jeysal commented Aug 16, 2019

Should definitely mention the language with the link though.

@SimenB
Copy link
Member

SimenB commented Aug 16, 2019

Yeah, agreed!

@SimenB SimenB merged commit 9ba4594 into jestjs:master Aug 18, 2019
@SimenB
Copy link
Member

SimenB commented Aug 18, 2019

Thanks!

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants