Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Delete obsolete FlowFixMe comments #8885

Merged
merged 5 commits into from
Aug 29, 2019

Conversation

pedrottimark
Copy link
Contributor

@pedrottimark pedrottimark commented Aug 28, 2019

Summary

As far as I can find, this is the last of them:

  • 1 in ./e2e/__tests__/detectOpenHandles.ts
  • 2 in ./e2e/__tests__/iterator-to-null-test.ts
  • 3 in ./e2e/__tests__/snapshot.test.ts
  • 1 in ./e2e/__tests__/snapshotMockFs.test.ts
  • 1 in ./e2e/__tests__/snapshotResolver.test.ts
  • 1 in ./e2e/__tests__/snapshotSerializers.test.ts

EDIT here is the command that I used to find those file in the project:

fgrep -lr --exclude-dir 'node_modules' --include '*.[j|t]s' '$FlowFixMe' .

Test plan

Local lint and tests, and then CI

Copy link
Collaborator

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope that's everything? Do we have any dangling "@flow" references maybe? Also it's an internal cleanup change so I do think it needs a changelog, but whatever :)

@codecov-io
Copy link

codecov-io commented Aug 28, 2019

Codecov Report

Merging #8885 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8885   +/-   ##
=======================================
  Coverage   64.11%   64.11%           
=======================================
  Files         275      275           
  Lines       11623    11623           
  Branches     2846     2845    -1     
=======================================
  Hits         7452     7452           
  Misses       3545     3545           
  Partials      626      626

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 700c17c...9f234d0. Read the comment docs.

@SimenB
Copy link
Member

SimenB commented Aug 28, 2019

Grep for @flow comments as well?

@pedrottimark
Copy link
Contributor Author

Good thinking, my friends. I will delete 16 occurrences of @flow under e2e

Here are 3 files that I am not sure whether to delete or keep the comment:

./examples/react-native/index.android.js
./examples/react-native/index.ios.js
./examples/react-native/Intro.js

so I do think it needs a changelog

If you mean do not then I am happy to get rid of it. Less is more :)

@SimenB SimenB merged commit ff81c28 into jestjs:master Aug 29, 2019
@pedrottimark pedrottimark deleted the delete-FlowFixMe branch August 29, 2019 14:23
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants