-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Delete obsolete FlowFixMe comments #8885
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hope that's everything? Do we have any dangling "@flow" references maybe? Also it's an internal cleanup change so I do think it needs a changelog, but whatever :)
Codecov Report
@@ Coverage Diff @@
## master #8885 +/- ##
=======================================
Coverage 64.11% 64.11%
=======================================
Files 275 275
Lines 11623 11623
Branches 2846 2845 -1
=======================================
Hits 7452 7452
Misses 3545 3545
Partials 626 626 Continue to review full report at Codecov.
|
Grep for |
Good thinking, my friends. I will delete 16 occurrences of Here are 3 files that I am not sure whether to delete or keep the comment:
If you mean do not then I am happy to get rid of it. Less is more :) |
6e636ed
to
40bcfc0
Compare
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
As far as I can find, this is the last of them:
./e2e/__tests__/detectOpenHandles.ts
./e2e/__tests__/iterator-to-null-test.ts
./e2e/__tests__/snapshot.test.ts
./e2e/__tests__/snapshotMockFs.test.ts
./e2e/__tests__/snapshotResolver.test.ts
./e2e/__tests__/snapshotSerializers.test.ts
EDIT here is the command that I used to find those file in the project:
Test plan
Local lint and tests, and then CI