Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add eslint-plugin-eslint-comments #9229

Merged
merged 2 commits into from
Nov 24, 2019
Merged

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Nov 24, 2019

Summary

Forces us to be more narrow when disabling rules, which is nice

Test plan

Green CI

@codecov-io
Copy link

Codecov Report

Merging #9229 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9229      +/-   ##
==========================================
- Coverage   65.08%   65.06%   -0.02%     
==========================================
  Files         278      278              
  Lines       11865    11865              
  Branches     2925     2925              
==========================================
- Hits         7722     7720       -2     
- Misses       3516     3517       +1     
- Partials      627      628       +1
Impacted Files Coverage Δ
packages/jest-haste-map/src/constants.ts 100% <ø> (ø) ⬆️
e2e/coverage-remapping/covered.ts 100% <ø> (ø) ⬆️
e2e/coverage-report/notRequiredInTestSuite.js 0% <ø> (ø) ⬆️
packages/test-utils/src/ConditionalTest.ts 0% <ø> (ø) ⬆️
e2e/coverage-transform-instrumented/covered.js 100% <ø> (ø) ⬆️
packages/expect/src/utils.ts 94.93% <0%> (-1.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c1addd...d79dfbf. Read the comment docs.

@SimenB SimenB merged commit 429877d into jestjs:master Nov 24, 2019
@SimenB SimenB deleted the eslint-comments branch November 24, 2019 14:46
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants